On 9/25/16 9:30 AM, Daniel Stenberg wrote:
> On Sat, 24 Sep 2016, Brad House wrote:
>
>>> The 'ares_socklen_t' seems to be a particular problem in the current ares_build.h file that sticks out. How does your
>>> suggested replacement look for that that?
>>
>> Can you elaborate? CARES_SIZEOF_ARES_SOCKLEN_T was completely unused by any logic what-so-ever, so I simply got rid
>> of it. Is that what you're asking about?
>
> The things I'm concerned about are the details that are gemerated in ares_build.h that are used in the public API/ABI.
>
> The 'ares_socket_t' type is one of those things. If we don't figure out that one at build-time, we need to add #ifdef
> magic in the public header that can replace what the configure script does to figure out the type.
>
The *type* detection was not modified in any way what-so-ever by my patch set.
Only the *size* detection of types (most of which were unused by the code).
Again, ares_socklen_t's *type* detection has not changed.
Did you see something in my patch that disputes this?
-Brad
Received on 2016-09-25