On 15/04/2010 13:06, Yang Tse wrote:
> 2010/4/12, Jérémy Lal wrote:
>
>> [...]: refreshed patch with only ares_mx_reply (not the ttl patch).
>> I also added a man page and some cleaning.
>> The patch applies on current git trunk (f28874d3)
>>
>> 0001-ares_parse_mx_reply.patch
>
> In Makefile.inc: could you place ares_parse_mx_reply.* lines in
> corresponding sorted order as the rest of the lines in this file
> already are ?
>
> In ares_data.h: move ARES_DATATYPE_MX_REPLY placement immediately
> below ARES_DATATYPE_ADDR_NODE in order to not modify other
> ares_datatype enum values.
>
> In ares_parse_mx_reply.3 your patch wrongly states author. You are the author.
>
> In ares_parse_mx_reply.c your patch has a 2009 copyright statement
> which does not apply to that file. Replace that line with 2010
> yourself or Daniel Stenberg.
>
I'd be happy to know if that patch is going
to be included in the next release, or not.
Thanks for any clue :)
Received on 2010-04-16