Subject: Re: How to contribute?

Re: How to contribute?

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Thu, 5 Jul 2018 09:26:13 +0200 (CEST)

On Wed, 4 Jul 2018, Basil 2 wrote:

First: welcome, and thanks for considering contributing to the c-ares project!

> I am going to implement CNAME redirection for TXT-type records. Which rules
> should I follow for this?
>
> Should I make a separate branch?

You should fork the github repo, create a local branch in that clone and then
submit a PR to c-ares using standard github/git best practices. Then you can
ammend that branch or even rebase, when you think its suitable.

> What are name requirements for it?

You mean the branch? You do the naming of your local branch, you can call it
whatever you like! =)

> Any other issues or advices?

1. Provide test case(s) for the new functionality

2. feel free to discuss your design/implementation here on the list or in the
    PR early so that you don't spend a lot of time/effort on something the
    team doesn't agree is the proper way forward

-- 
  / daniel.haxx.se
Received on 2018-07-05