Subject: Re: [PATCH] Cmake-ify c-ares -- v2

Re: [PATCH] Cmake-ify c-ares -- v2

From: Gregor Jasny via c-ares <c-ares_at_cool.haxx.se>
Date: Mon, 3 Oct 2016 11:23:13 +0200

Hello,

On 29/09/2016 21:34, Gregor Jasny wrote:
> On 29/09/2016 14:34, David Drysdale wrote:
>>
>> Gregor / Daniel, did you have any thoughts on the CMake change?
>
> Yes, I'm reviewing it but the CVE took most of my spare time.

I think as soon as the latest comments are addressed, the PR is good to
be merged. Any later changes could be done incrementally.

I'm still no big fan of building shared and static libraries within the
same build directory. But this defaults to "OFF" so it does not harm either.

Thanks,
Gregor
Received on 2016-10-03