On 9/28/16 7:40 AM, David Drysdale wrote:
> On Wed, Sep 28, 2016 at 1:09 AM, Brad House
> <brad_at_mainstreetsoftworks.com> wrote:
>> On 9/27/16 10:26 AM, David Drysdale via c-ares wrote:
>>>
>>> On Tue, Sep 27, 2016 at 2:52 PM, Gregor Jasny via c-ares
>>> <c-ares_at_cool.haxx.se> wrote:
>>>>
>>>> Hi Brad,
>>>>
>>>> On 27/09/2016 13:44, Brad House via c-ares wrote:
>>>>>
>>>>> I've attached v2 of my CMake patch for c-ares. The changes are:
>>>>> * Sync with master (no configure-time type size checks)
>>>>> * Support iOS multi-arch building
>>>>> * Require only CMake v2.8
>>>>>
>> ...
>>>>
>>>>
>>>> If you don't mind could you please create a pull request on github and
>>>> ping me (gjasny) there?
>>>>
>>>> Thanks,
>>>> Gregor
>>>
>>>
>>> Also, it would be great if you could add some integration with
>>> .travis.yml,
>>> so we can see the build results in the pull request.
>>>
>>> Thanks,
>>> David
>>>
>>
>> I must say, I've never messed with travis. Will I need to create a new
>> travis
>> account to test this, or is this something that if I modify the .travis.yml
>> in
>> the pull request it will cause it to build?
>
> Any pull request will get run through Travis automatically [1], so you
> shouldn't need a Travis account.
>
> If you're not used to Travis, it's probably easier for me to add
> something -- first attempt at [2], with output at [3]. Does that look
> sensible?
>
> D.
>
> [1] https://travis-ci.org/c-ares/c-ares/builds/163269776
> [2] https://github.com/daviddrysdale/c-ares/commit/fc7917e3c5b99ca4f9be66ea5060a2b49a5bbcec
> [3] https://travis-ci.org/daviddrysdale/c-ares/builds/163350713
>
Seems reasonable to me. Built both shared and static variants and test utilities,
and tests ran successfully.
-Brad
Received on 2016-09-28