Subject: Re: [PATCH] Cmake-ify c-ares -- v2

Re: [PATCH] Cmake-ify c-ares -- v2

From: Gregor Jasny via c-ares <c-ares_at_cool.haxx.se>
Date: Tue, 27 Sep 2016 15:52:41 +0200

Hi Brad,

On 27/09/2016 13:44, Brad House via c-ares wrote:
> I've attached v2 of my CMake patch for c-ares. The changes are:
> * Sync with master (no configure-time type size checks)
> * Support iOS multi-arch building
> * Require only CMake v2.8
>
> The main thing that still needs to be done is to build the tests,
> however I'm not seeing how to do that with CMake 2.8 as was requested
> since it doesn't have C++11 support (needed to set the right flags
> during compilation). Even with later CMake versions, I'm not exactly
> sure how to detect a C++11 compiler ... so it will take quite a bit of
> research. (It doesn't help that I'm a C guy and try not to touch C++).
>
> That said, I don't know if that is a show-stopper for an experimental
> build system distributed in parallel with the primary autotools build
> system.

If you don't mind could you please create a pull request on github and
ping me (gjasny) there?

Thanks,
Gregor
Received on 2016-09-27