Subject: [PATCH] Fixes for disabling tests properly

[PATCH] Fixes for disabling tests properly

From: Brad House <>
Date: Wed, 9 Mar 2016 08:50:42 -0500

The patch in master for disabling tests is not a good solution because it
forces you to pass --disable-tests, rather than auto-detect if your system
can support the tests in the first place. Many (most?) systems do not have
C++11. This also causes issues when chain-building c-ares, the hosting system
needs to be updated to support passing this additional flag if necessary,
it doesn't seem reasonable to add this requirement which breaks compatibility.

The attached patch will auto-detect if the system can build the tests
and automatically disable them if it cannot. If you pass --enable-tests
to configure and the system cannot build them either due to lack of system
support, or because cross-compilation is being used, it will throw an
appropriate error since the user indicated they really did want the tests.

Does anyone have any objections to this?


Received on 2016-03-09