Subject: Re: [PATCH] Add ares_set_socket_configure_callback()

Re: [PATCH] Add ares_set_socket_configure_callback()

From: Andrew Ayer <agwa_at_andrewayer.name>
Date: Tue, 9 Feb 2016 10:11:00 -0800

On Tue, 9 Feb 2016 16:44:36 +0000
David Drysdale <drysdale_at_google.com> wrote:

> Hi Andrew,
>
> Thanks for the patch -- and thanks for including a man-page update and
> a test update;
> I've scattered a few minor comments below.

Hi David,

Thanks for the review. I've updated the pull request to address your
comments, and included an updated patch below.

I also noticed that the type of the callback wasn't documented
anywhere, so I updated the man page to mention it. I also updated the
man page for ares_set_socket_callback in a separate commit.

Regards,
Andrew
Received on 2016-02-09