Subject: Re: [PATCH] ares_parse_txt_reply: add `record_start` field

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

From: Fedor Indutny <fedor_at_indutny.com>
Date: Mon, 1 Feb 2016 15:34:35 -0500

Hello David,

I have made fixes to the patch from 2015-03-21, according to your comments.

Please take a look.

Thank you!

On Mon, Feb 1, 2016 at 11:12 AM, David Drysdale <drysdale_at_google.com> wrote:

> The first version of the patch still has the problem that it changes the
> size of
> an existing structure and thus alters the ABI. Personally, I prefer the
> patch
> you sent 2015-03-21, just without the age+reserved fields (and with the
> other
> tweaks I suggested 2016-01-28).
>
> D.
>
> On Thu, Jan 28, 2016 at 11:24 PM, Fedor Indutny <fedor_at_indutny.com> wrote:
>
>> No worries at all!
>>
>> Does the first version of patch look better now?
>>
>> Thank you,
>> Fedor.
>>
>> On Thu, Jan 28, 2016 at 5:05 PM, Daniel Stenberg <daniel_at_haxx.se> wrote:
>>
>>> On Thu, 28 Jan 2016, Fedor Indutny wrote:
>>>
>>> Just FYI, this `age` thing was actually suggested by you earlier in this
>>>> thread, but I will be more than happy to remove it.
>>>>
>>>
>>> I know, and I'm sorry I lead you down that path! :-(
>>>
>>> --
>>>
>>> / daniel.haxx.se
>>>
>>
>>
>

Received on 2016-02-01