On Mon, Jan 18, 2016 at 8:24 AM, Gregor Jasny <gjasny_at_googlemail.com> wrote:
> Hi,
>
> David Drysdale wrote:
>>
>> Thanks, I've pulled that change in (with a trvial tweak to break out of
>> the loop on strdup failure).
>
>
> thanks for merging.
>
> I would suggest that you remove the tweak because now deallocation is
> broken. The problem is that now the upper array elements are uninitialized
> on strdup failure. So one either has to change the malloc to a calloc or
> 'correct' the channel->ndomains value before breaking.
Good point, sorry -- I shouldn't have tweaked the patch. I'll push an update
to match your original patch.
> Thanks,
> Gregor
Received on 2016-01-18