Subject: Re: [PATCH] Use libresolv to initialize cares on iPhone targets

Re: [PATCH] Use libresolv to initialize cares on iPhone targets

From: Gregor Jasny <gjasny_at_googlemail.com>
Date: Mon, 18 Jan 2016 09:24:55 +0100

Hi,

David Drysdale wrote:
> Thanks, I've pulled that change in (with a trvial tweak to break out of the loop on strdup failure).

thanks for merging.

I would suggest that you remove the tweak because now deallocation is
broken. The problem is that now the upper array elements are
uninitialized on strdup failure. So one either has to change the malloc
to a calloc or 'correct' the channel->ndomains value before breaking.

Thanks,
Gregor
Received on 2016-01-18