Subject: Re: Unit test suite for c-ares

Re: Unit test suite for c-ares

From: Daniel Stenberg <>
Date: Fri, 30 Oct 2015 09:53:46 +0100 (CET)

On Thu, 22 Oct 2015, David Drysdale wrote:

> By the way, I should observe that so far I've only seen one thing that might
> count as a bug, even running with sanitizers/fuzzers etc -- so kudos for the
> quality of the code!


> That one thing is in this change:
> which polices the top 2 bits of a label length to be (only) 00 or 11
> -- seem sensible?

Seems perfectly reasonable to me!

> More generally, what's the best way to proceed with these changes? Given
> that test/ is independent, it seems like it would probably be OK for me to
> push things in there without getting a second opinion, but the things that
> affect the main library itself should have someone else take a look.

I agree with that, go ahead!

Once this gets merged, we can also add some travis-ci integration so that we
can get some gihub fanciness going and even have tests running for
pull-requests etc.

Received on 2015-10-30