Subject: Re: [PATCH 3/5] Free temporary variable in error path

Re: [PATCH 3/5] Free temporary variable in error path

From: David Drysdale <drysdale_at_google.com>
Date: Mon, 22 Sep 2014 10:53:26 +0100

LGTM

On Fri, Sep 19, 2014 at 7:51 PM, Gregor Jasny <gjasny_at_googlemail.com> wrote:

> Fix Coverity CID 56890
>
> Signed-off-by: Gregor Jasny <gjasny_at_googlemail.com>
> ---
> acountry.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/acountry.c b/acountry.c
> index 210ef84..fae9f9f 100644
> --- a/acountry.c
> +++ b/acountry.c
> @@ -562,6 +562,7 @@ static void find_country_from_cname(const char *cname,
> struct in_addr addr)
> if ((z0 != 'z' && z1 != 'z') || dot != cname+4)
> {
> printf("Unexpected CNAME %s (ver_1)\n", cname);
> + free(ccopy);
> return;
> }
> }
> @@ -572,12 +573,14 @@ static void find_country_from_cname(const char
> *cname, struct in_addr addr)
> if (z0 != 'z' && z1 != 'z')
> {
> printf("Unexpected CNAME %s (ver_2)\n", cname);
> + free(ccopy);
> return;
> }
> }
> else
> {
> printf("Unexpected CNAME %s (ver?)\n", cname);
> + free(ccopy);
> return;
> }
>
> --
> 1.8.5.2 (Apple Git-48)
>
>
Received on 2014-09-22