Subject: Re: Patch for fixing the slow DNS lookup issue

Re: Patch for fixing the slow DNS lookup issue

From: David Drysdale <drysdale_at_google.com>
Date: Fri, 25 Jul 2014 09:34:23 +0100

How about the attached?

On Thu, Jul 24, 2014 at 6:07 PM, Jakub Hrozek <jhrozek_at_redhat.com> wrote:

> On Thu, Jul 24, 2014 at 05:11:41PM +0100, David Drysdale wrote:
> > On Mon, May 26, 2014 at 9:08 AM, Jakub Hrozek <jhrozek_at_redhat.com>
> wrote:
> >
> > > On Sat, May 24, 2014 at 02:29:16PM +0200, Daniel Stenberg wrote:
> > > > On Thu, 22 May 2014, Jakub Hrozek wrote:
> > > >
> > > > >I can't comment on the patch contents myself at all, because I'm
> > > > >not a Windows developer, but I guess it would be easier for others
> > > > >to review if the patch was a git-formatted one or a github pull
> > > > >request since c-ares uses git and github anyway.
> > > >
> > > > I generally discourage github pull requests simply because it then
> > > > only alerts those who subscribe to those on github (and it isn't
> > > > easy for us to tell who got it or care about it) and it doesn't send
> > > > the patch here for review.
> > >
> > > Yeah, this is my pain point about github as well..if only there was a
> > > way to securely enable sending all pull requests to a mailing list..but
> > > unfortunately I couldn't find one that would also make it hard to
> > > request password changes to be sent to the list.
> >
> >
> > As a slight mitigation, is it worth adding a CONTRIBUTING file at the top
> > level advising people to send patches to the mailing list?
> >
> > According to the GitHub help, adding that file should at least set up a
> > notice that potential contributors might spot:
> >
> https://help.github.com/articles/how-do-i-set-up-guidelines-for-contributors
>
> Good idea, there already is a note about this list in the README that is
> displayed when you navigate to https://github.com/bagder/c-ares but
> making this info more prominent certainly wouldn't hurt.
>

Received on 2014-07-25