Subject: Re: [PATCH] Move memset call below platform-specific declarations

Re: [PATCH] Move memset call below platform-specific declarations

From: Jakub Hrozek <jhrozek_at_redhat.com>
Date: Wed, 23 Jul 2014 18:02:33 +0200

On Tue, Jul 01, 2014 at 09:47:43AM +0100, David Drysdale wrote:
> On Tue, Jul 1, 2014 at 9:36 AM, Jakub Hrozek <jhrozek_at_redhat.com> wrote:
>
> > On Mon, Jun 09, 2014 at 10:22:23AM +0100, David Drysdale wrote:
> > > Hi folks,
> > >
> > > A GitHub commenter [1] says that my recent change to ahost.c has
> > > problems compiling on Windows + C89 platforms. I've attached a
> > > putative patch below, but I don't have access to the relevant platform
> > > to check it -- can anyone confirm the problem & solution?
> > >
> > > Thanks,
> > > David
> > >
> > > [1]
> > https://github.com/bagder/c-ares/commit/ee22246507c9#commitcomment-6587616
> >
> > LGTM, but I lack the environment to test the patch as well. I've asked the
> > github commenter to test.
> >
>
> Thanks -- I should have thought of that!

I'm sorry for the delay. The reporter confirmed that a similar patch
solved his issue. Since I don't see any negative consequences, I'm going
to push the patch.

Please note that I haven't been able to reproduce the problem myself as
I don't have access to Windows development environment. Feel free to
revert the patch and yell at me on this list if the patch is not correct
:-)
Received on 2014-07-23