Subject: Re: [PATCH] ares_parse_txt_reply: add `record_start` field

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

From: Saúl Ibarra Corretgé <saghul_at_gmail.com>
Date: Wed, 11 Jun 2014 11:40:04 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/06/2014 06:30 AM, Fedor Indutny wrote:
> Thinking about it, I have only one hacky idea for implementing it
> without bloating the code base, or allocating excessive bytes.
>
> The TTL could be put into the `len` field of record when `txt` is
> `NULL`.
>
> Does it seems good to you guys?
>

Sounds a bit hacky... Not sure if TTL applies to each individual
record or it's global, in that case it would just be an extra int* on
the function, right?

>
> On Wed, May 28, 2014 at 6:12 PM, Fedor Indutny <fedor_at_indutny.com
> <mailto:fedor_at_indutny.com>> wrote:
>
> Oh right, will do it.
>
>
> On Wed, May 28, 2014 at 4:59 PM, Saúl Ibarra Corretgé
> <saghul_at_gmail.com <mailto:saghul_at_gmail.com>> wrote:
>
> On 05/27/2014 12:01 PM, Fedor Indutny wrote:
>> Sure, here are attached changes.
>
>> Please let me know if I should improve them even further.
>
>
> Looks good to me, FWIW.
>
> Someone asked if you could add the TTL data there, maybe taking
> the same approach as ares_parse_a_reply? Something like:
>
> ares_parse_chunked_txt_reply (const unsigned char *abuf, int alen,
> struct ares_txt_reply **txt_out, struct ares_addrttl *addrttls, int
> *naddrttls)
>
>
> Cheers,
>
>
>
>

- --
Saúl Ibarra Corretgé
bettercallsaghul.com

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iQIcBAEBAgAGBQJTmCPzAAoJEEEOVVOum8BZULAQAKzdhJQTf3g/jexKNlp7exu6
iGsF2nAncmGXeCsu/aKdUzoTD4ouuPiEVM1yOuNLpEFB05yMEGP+Pq1P2hL0UPKU
eRdetfeFH+eafhyOtPSvWr/f+AJMBHl/Q6U9Tp6eeif/hynfUBf0YLYUqKhScJZL
x2UnLIS2fnE/MCwWsZhGIy71TbrqLminNMopC6Osek69LsRwCi7+377GyNH2yklv
nBdWdUWplCfNdYnjG8T4lXLm0Mk26HEaQYQWN1ZtzLx9unTBCdWIxjnrrkdBx6PF
RlIrTPqXDkU/lpyc9BcW3KlfIK6Wngdu1RLlr6RIY3dCkM+Sq0UW41pf7Hm/6Pq4
aMUBga/RLMGdVEbu5elfO5J1U5hDiHP4TV6CoCTAuQ4hlKz07i0XTcuDfxJcexsU
fcxtm16dodV/0sk0m8dON+jcHZU2A/CJMaaWqbRoGCEH7IJ2Bdx8d4seH3MgHVzK
tAFWaWSBYfqt7XMphT0i2sn8STOHj9E/JkGykOZ8PFLGEDWwdLLd7VKqiUUv6N6z
3PCjJsZ13j32CMVC9cWbVzJjmZS14YQViujBUDcLXU4d/XlbgGYtGucUJPfq9REP
RUudttoysRamAaIdAt2Sfc8t6Kr+xhTTa7rMOgJwwaaXGaEg09w/lALAdV6b3Q2/
uo3522LRpX7t4o3xaOfv
=3AYx
-----END PGP SIGNATURE-----
Received on 2014-06-11