Subject: Re: [PATCH] ares_parse_txt_reply: add `record_start` field

Re: [PATCH] ares_parse_txt_reply: add `record_start` field

From: Fedor Indutny <fedor_at_indutny.com>
Date: Thu, 29 May 2014 02:12:40 +0400

Oh right, will do it.

On Wed, May 28, 2014 at 4:59 PM, Saúl Ibarra Corretgé <saghul_at_gmail.com>wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 05/27/2014 12:01 PM, Fedor Indutny wrote:
> > Sure, here are attached changes.
> >
> > Please let me know if I should improve them even further.
> >
>
> Looks good to me, FWIW.
>
> Someone asked if you could add the TTL data there, maybe taking the
> same approach as ares_parse_a_reply? Something like:
>
> ares_parse_chunked_txt_reply (const unsigned char *abuf,
> int alen,
> struct ares_txt_reply **txt_out,
> struct ares_addrttl *addrttls,
> int *naddrttls)
>
>
> Cheers,
>
> - --
> Saúl Ibarra Corretgé
> bettercallsaghul.com
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> Comment: Using GnuPG with Icedove - http://www.enigmail.net/
>
> iQIcBAEBAgAGBQJThd2tAAoJEEEOVVOum8BZR9MP/RMgT5oqH4ZmSaQ41Zo9Igpe
> qwy3SJm5YY/P/fa16uN2m7kJbyU5ksThUVj9c8PDA6fYecEqZTQMHY+we3UYOv1w
> rwp2/GqAEv3Sx6fjdQ9Rm8KVwIDQRL8wb7DlxyMYiK+Oae18tokx/gFacEUA9g0F
> ulH/uiBXgEnmDTq38H9rMTWn14PWbeHYl0XQNHDrGBAJkKuY+xnPmy+STG0ER5E0
> dGIVfi2TgtEUhgnj6eyOqNLIV1cZDXBerUoIiXtVDejZNRSXE/Y59SPreCNgV+ZF
> l43LPVbenP2EAlFUnZSq+OcD+/kQLuYs74jgSK5K2FyBMozhkLn84Vf/oDn8C9po
> nVWpt8DmiJAlJ+QUkEU1s6SA6LWSF2ogN3ekTyFgN8buicNgS5B4xPFSqsU5E1IJ
> eigEB1Wjvsz0bJDlfxi4ztNpd/5WK7mmiexO4HBXkY+RfbWpBBKvt6DkMjJsNtQa
> XzvHsRIXIfzEp8/yigJ0gYhNkuOpaD4I5yTkbixVvbnd01dC7zON9sBNuCsqwnPj
> dRQE5QauM28hUpkBLHtsMKGRclzOMVHGb1GKewX8qSPAFRoOHRGdVr786w8afYMe
> /LZCWEJScohwq00X4JvT5qL8C6oWWqYrRXL93K1DK64tS1k5wyT/aN7F45RA1jLL
> 8n+WOaaz6krHdWV3LF+Y
> =vsvs
> -----END PGP SIGNATURE-----
>
Received on 2014-05-29