Subject: Re: ares_parse_txt_reply's output is not usable for DNS-SD

Re: ares_parse_txt_reply's output is not usable for DNS-SD

From: Patrick Valsecchi <pvalsecc_at_cisco.com>
Date: Mon, 15 Apr 2013 14:40:17 +0200

On 04/15/2013 02:00 PM, Tommie Gannert wrote:
> 2013/4/15 Patrick Valsecchi <pvalsecc_at_cisco.com
> <mailto:pvalsecc_at_cisco.com>>
>
> - ares_parse_a_reply: I have a feeling that rr_name is leaked if
> the code reaches lines 157 or 168
>
> - ares_parse_aaaa_reply: same suspicions
>
>
> By a quick look at GitHub master, I think the code looks good.
>
My wrong.

> Do you want a patch for all that? Who has the authority to accept
> patches?
>
>
> I guess the overall "fixes are good" applies. Daniel is the headmaster
> (that's actually funny in Git terms. I need more tea.)
>

In attachment, you find a patch against the current git that includes
yours and the fixes for the other problems. I tested against my feature
tests on Linux, but I use only parsing of PTR, SRV and TXT. There are no
test included with the c-ares source code?

Received on 2013-04-15