Subject: RE: [PATCH] Extension mechanisms for DNS

RE: [PATCH] Extension mechanisms for DNS

From: Ghennadi Procopciuc <gprocopciuc_at_ixiacom.com>
Date: Fri, 10 Aug 2012 09:22:41 +0000

> I like a new function. I don't like all the new code duplication. ares_mkquery
> and ares_create_query should be able to be basically the same function with
> two different entries. ares_mkquery() can just call the new funtion with the
> extra argument filled in.

Fixed in version 4.

> Also, I would like the documentation to deprecate the old API and favour the
> use of the new one.

From previous version:
+Deprecated function. See \fIares_create_query(3)\fP instead!
...
+Usage of \fIares_mkquery(3)\fP is deprecated, whereas the function is
+equivalent to \fIares_create_query(3)\fP with \fBmax_udp_size\fP set to
+0.

Thanks,
Ghennadi

Received on 2012-08-10