Subject: Re: Patch for Android NDK build

Re: Patch for Android NDK build

From: Wayne Piekarski <wayne_at_tinmith.net>
Date: Sun, 15 Apr 2012 17:37:27 -0700

After reading the discussion in the included link, it seems as though
some of the older NDKs do not define __ANDROID__ properly.

So if we want c-ares to be compatible with older NDK releases, then we
should probably test for both __ANDROID__ or ANDROID.

If we want to be compatible only with the latest NDK releases, then only
__ANDROID__ should be fine.

I'm not sure if there was any similar discussion when the similar patch
was made to CURL. Perhaps the safest bet would be to check for both?

regards,
Wayne

On 15/04/2012 4:55 PM, Gerald Combs wrote:
> On 4/15/12 4:34 PM, Guenter wrote:
>> Thanks! But can you please explain to me why its not enough to check for
>> __ANDROID__ only since the NDK toolchain defines it; and everyone who
>> wants to use another toolchain can still define it self?
>
> According to David Turner you should only check for __ANDROID__:
>
> http://groups.google.com/group/android-ndk/browse_thread/thread/71ff7f7f548b5e5b/573450fddf2b8dab
>
Received on 2012-04-16