On Mon, May 16, 2011 at 12:39:33AM +0200, Daniel Stenberg wrote:
> On Fri, 13 May 2011, David Stuart wrote:
>
> >Here's a 7zip file containing the changed files for my patch
>
> Please send us (unified) patches for changes as made with diff -u or
> plain git. Complete replacement files are inconvenient. I've
> attached the patch to this mail, generated from your files compared
> to what's in git right now.
[snip]
> + const size_t ipv4_size = sizeof("255.255.255.255,") - 1;
> + const size_t ipv6_size = sizeof("ffff:ffff:ffff:ffff:ffff:ffff:255.255.255.255,") - 1;
Hmm, theoretically speaking, an IPv6 address might be even longer than
that (think link-local addresses with %ifname at the end). However,
I stronly doubt somebody would actually *use* something much longer...
but then again, this last sentence fragment has led to some very, very
bad buffer overflow exploits over the last twenty years :)
G'luck,
Peter
-- Peter Pentchev roam_at_ringlet.net roam_at_FreeBSD.org peter_at_packetscale.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 .siht ekil ti gnidaer eb d'uoy ,werbeH ni erew ecnetnes siht fI