Subject: Re: [PATCH] Do not use sized constants in public headers

Re: [PATCH] Do not use sized constants in public headers

From: Daniel Stenberg <daniel_at_haxx.se>
Date: Wed, 16 Jun 2010 14:38:54 +0200 (CEST)

On Wed, 16 Jun 2010, Jakub Hrozek wrote:

> But it seems that the CARES_SIZEOF_ARES_SOCKLEN_T and CARES_CONFIGURE_LONG
> are only used for check that the configure time constant equals to the build
> time constant. It is used nowhere in the actual code, therefore my proposal
> (also backed by Daniel's in the referenced bug) to remove them, at least
> from public headers into some private part of code if not completely.

Yes, there seems to be no point to add this burden to users of c-ares unless
we actually have a reason to, and with these defines that aren't used by the
public c-ares API I think we can just remove them for now, or possibly make
them private.

If we figure out a reason in the future why we need them there, we can always
put them back then.

-- 
  / daniel.haxx.se
Received on 2010-06-16