Subject: Re: [PATCH] Do not use sized constants in public headers

Re: [PATCH] Do not use sized constants in public headers

From: Jakub Hrozek <jhrozek_at_redhat.com>
Date: Wed, 16 Jun 2010 14:34:03 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/16/2010 01:53 PM, Yang Tse wrote:
> On some systems differences in ares_build.h only depend on 32 vs 64
> bit build target. These should be very easy for the packager to come
> up with a unified ares_build.h.
>
> But there are other systems on which it is not only a matter of 32 vs
> 64 bit. socklen_t data type (and size) depends on interface or socket
> library being used. HPUX comes to my mind in this moment. So in order
> to allow proper usage we have to live with this stuff.
>

Thank you for explaining! I understood that the reason is portability.
But it seems that the CARES_SIZEOF_ARES_SOCKLEN_T and
CARES_CONFIGURE_LONG are only used for check that the configure time
constant equals to the build time constant. It is used nowhere in the
actual code, therefore my proposal (also backed by Daniel's in the
referenced bug) to remove them, at least from public headers into some
private part of code if not completely.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkwYxLsACgkQHsardTLnvCXgQwCgkfyNyzwe5gjLTRL0XE3QS6UY
G8QAnjyVm9MZvIJanRBDiP2Wo+fL95Zq
=btdY
-----END PGP SIGNATURE-----
Received on 2010-06-16