Subject: Re: request for review ares_parse_mx_reply

Re: request for review ares_parse_mx_reply

From: Krishna Rajendran <krishna_at_rajendran.org>
Date: Wed, 7 Apr 2010 08:06:52 -0400

On Wed, Apr 7, 2010 at 7:16 AM, Krishna Rajendran <krishna_at_rajendran.org> wrote:
> It looks fine to me otherwise and seems to work as expected.

Spotted one issue. In ares_malloc_data in ares_data.c. The wrong union
member is being used.

+ case ARES_DATATYPE_MX_REPLY:
+ ptr->data.srv_reply.next = NULL;
+ ptr->data.srv_reply.host = NULL;
+ ptr->data.srv_reply.priority = 0;
+ break

-Krishna
Received on 2010-04-07