-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 11/20/2009 02:54 AM, Yang Tse wrote:
> 1)
>
> In ares.h there's a comment mentioning that a couple of structs should
> be renamed to avoid name space pollution, prefixing ares_ to them.
> Obviously the change should be reflected elsewhere, code and man
> pages.
>
> Changing the above would not require existing apps to be recompiled,
> so theoretically no ABI breakage here, but apps depending on these
> could need to be modified to match the new struct name when
> recompiled.
>
> So I think it is a good moment to rise the issue and ask if someone is
> against this change. Or if we actually prefer it to happen right away.
>
See attached patch prefix-structures-with-ares.patch
> 2)
>
> Man pages should be revisited verifying that the data type of the
> prototypes match those present in ares.h, I remember once seeing at
> least one discrepancy. Don't really know if there are many
> discrepancies but I don't think so.
OK, I saw you did some changes already, so I hope I won't be stepping on
your toe with this, but see the attached
sync-man-pages-with-prototypes.patch patch.
Hope this helps,
Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAksJToAACgkQHsardTLnvCXLtwCgzv/upJYQe1ZN1VnhrDUGxAQx
OnkAoKuUVTaqybaK4DNZjuxlnUGYUy56
=WUa1
-----END PGP SIGNATURE-----