Subject: Re: [PATCH] ares_parse_srv_reply

Re: [PATCH] ares_parse_srv_reply

From: Jakub Hrozek <jhrozek_at_redhat.com>
Date: Wed, 15 Jul 2009 13:37:43 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/02/2009 05:35 PM, Uli wrote:
> With "this" I meant again the memcpy() call.
>
> In case it wasn't clear (sorry!): My only complaint was that you used memcpy()
> to initialize only part of a larger integer variable. If you use some *int16_t
> variable this is fixed.
>

OK, I'm attaching a new version of the patch which does not use memcpy
at all. Hope the code is clearer now.

Daniel, can you see any other issues with the patch? Is c-ares upstream
interested in merging this functionality?

Thanks,
Jakub Hrozek
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkpdv4cACgkQHsardTLnvCWcOgCffZJaR+Wvwi81W/3dIoYZfyOE
O/wAoMArxIk8pE1CI2FV6mycfrb4jPFO
=q4gG
-----END PGP SIGNATURE-----

Received on 2009-07-15