Subject: Re: ares_expand_name() return codes

Re: ares_expand_name() return codes

From: Phil Blundell <pb_at_reciva.com>
Date: Sun, 11 Jan 2009 10:37:45 +0000

On Sat, 2009-01-10 at 20:08 +0100, Daniel Stenberg wrote:
> ares_expand_name() is in the API and it doesn't explicitly deal with
> responses, thus making it returning ARES_EBADRESP seems odd.
>
> But internally (like in all the ares_parse_*_reply() functions) in c-ares when
> ares_expand_name() is used on a response, I think a returned error could very
> well be translated to a ARES_EBADRESP to return from the public function that
> was called.

Ah, right, I hadn't noticed that ares_expand_name was in the public API.

Here's a patch, then.

p.

Received on 2009-01-11