Subject: Re: [PATCH] Return TTL data

Re: [PATCH] Return TTL data

From: Bram Matthys (Syzop) <syzop_at_vulnscan.org>
Date: Wed, 10 Oct 2007 20:53:14 +0200

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Personally, I'm more unhappy with the 'Report number of timeouts back to the
user code' API change.
IMO one should be careful with breaking the API, and doing so for timeout
statistics is not worth it (personally I'm a fan of passing structs around
which contain useful fields, so you don't break the function call API,
anyway maybe not very relevant here since there might not be much to be
passed around in the future.. anyway, my point still stands @ breaking api).

The TTL patch seems logical though, if you call a parse-XYZ-function, you'd
expect it to return all the parsed info, not omit something like the TTL.

Regards,

        Bram.

Steinar H. Gunderson wrote:
> On Fri, Sep 28, 2007 at 05:49:56PM +0200, Steinar H. Gunderson wrote:
>> Off the top of my head, I believe this is the last API-changing patch. It
>> simply makes the TTL data for a given query available to the caller, if the
>> caller wants it. Documentation is updated accordingly.
>
> Was there any feedback on this? I'd be happy to just commit it if there's no
> objections.
>
> /* Steinar */

- --
Bram Matthys
Software developer/IT consultant syzop_at_vulnscan.org
PGP key: www.vulnscan.org/pubkey.asc
PGP fp: 8DD4 437E 9BA8 09AA 0A8D 1811 E1C3 D65F E6ED 2AA2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)

iD8DBQFHDR+a46ioc5305a8RApgJAJ40jd8ki5cLCkF2zLIAWTdrVU0hfwCfesuX
fvs10hm3lT9aWG8jyofXRKY=
=ed6e
-----END PGP SIGNATURE-----
Received on 2007-10-10